Skip to content

Document IN() #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document IN() #619

wants to merge 1 commit into from

Conversation

masylum
Copy link

@masylum masylum commented Jul 13, 2023

Hi there! I'm pretty new to this project and I think this is the best time to contribute documentation.
The tutorial is amazing, but missing a formal reference makes finding some advanced features a bit difficult. For instance, since I'm still not 100% sure how the integration with SQLAlchemy works, I had to search how to do in_. I found this issue here #353 which explains perfectly how to do it.

I've went ahead and added the documentation on the where tutorial. My only gotcha here is that the numeric examples make it hard to add new examples in between. I'm not sure renaming all the tutorials is the best approach. This is a very similar problem as creating taxonomies in design systems, this is why people name things in hundreds (100, 200, 300...), so if a new thing needs to be added in between it can be added without having to rename things afterwards. In my case, I've just added a 5 after the 6 to denote "this tutorial goes between the 6th and the 7th".

I hope this is useful!

@tiangolo tiangolo added the docs Improvements or additions to documentation label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants